[Relay][Keras][Bugfix] fix the converters of GRU and SimpleRNN about the go_backwards attribute#15829
Merged
echuraev merged 3 commits intoapache:mainfrom Sep 29, 2023
jikechao:fix_gru_go_backwards
Merged
[Relay][Keras][Bugfix] fix the converters of GRU and SimpleRNN about the go_backwards attribute#15829echuraev merged 3 commits intoapache:mainfrom jikechao:fix_gru_go_backwards
echuraev merged 3 commits intoapache:mainfrom
jikechao:fix_gru_go_backwards
Conversation
jikechao
changed the title
jikechao
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two similar bugs with the issue: #15176
For the convert function of GRU and SimpleRNN in the Keras frontend, they overlook the parsing for
go_backwardsattribute.Thus, they can lead to wrong inference results.
This PR fixed them and added two corresponding regression tests.
cc @echuraev @Hzfengsy @merrymercy