Skip to content

[Tests] Check int8+int32 testcases in test_estimate_peak_flops_cpu#16019

Merged
lhutton1 merged 1 commit intoapache:mainfrom
PhilippvK:fix-roofline-unittest-dtype
Oct 31, 2023
Merged

[Tests] Check int8+int32 testcases in test_estimate_peak_flops_cpu#16019
lhutton1 merged 1 commit intoapache:mainfrom
PhilippvK:fix-roofline-unittest-dtype

Conversation

@PhilippvK
Copy link
Copy Markdown
Contributor

Pytest param fixture for dtypes was not used resulting in these two test cases not being checked.

Pytest param fixture for dtypes was not used resulting in these two test cases not beeing checked.
Copy link
Copy Markdown
Contributor

@quic-sanirudh quic-sanirudh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

@lhutton1 lhutton1 merged commit 5b561a6 into apache:main Oct 31, 2023
@lhutton1
Copy link
Copy Markdown
Contributor

Thanks @PhilippvK @quic-sanirudh!

@PhilippvK PhilippvK deleted the fix-roofline-unittest-dtype branch January 23, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants