[RUNTIME][CLML] Fix for Softmax op for 4D tensors#16328
Merged
srkreddy1238 merged 1 commit intoapache:mainfrom Jan 18, 2024
Merged
[RUNTIME][CLML] Fix for Softmax op for 4D tensors#16328srkreddy1238 merged 1 commit intoapache:mainfrom
srkreddy1238 merged 1 commit intoapache:mainfrom
Conversation
Fixed the softmax layer for 4D tensors to support for NCHW and NHWC layout types. Enabled relevant test cases for softmax layer
Contributor
Author
|
@echuraev Can you please take a look and let me know your feedback. |
echuraev
reviewed
Jan 9, 2024
Contributor
echuraev
left a comment
echuraev
left a comment
There was a problem hiding this comment.
Just a small question. In general LGTM. @srkreddy1238 could you please review this PR?
| shape)}); | ||
| } else { | ||
| this->layer_.in_placeholder.insert( | ||
| {nid, MakeCLMLTensorFromJSONNode(node, layout, dtype, node_data, shape)}); |
Contributor
There was a problem hiding this comment.
Is it necessary to add an ICHECK to check the layout or not?
Contributor
Author
There was a problem hiding this comment.
This if else statement is to support other layout format CL_TENSOR_LAYOUT_NHWC_QCOM as well for input to the clml subgraph.
Thanks for review, please let me know your opinion! @echuraev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the softmax layer for 4D tensors to support for NCHW and NHWC layout types.
Enabled relevant test cases for softmax layer