[Bugfix][Unity] Recover MSVC/NVCC/ROCm/Vulkan#16414
Merged
tqchen merged 1 commit intoapache:unityfrom Jan 17, 2024
Merged
Conversation
This PR upstreams a few commits that recovers the unity branch from broken wheel packages. It includes the following changes: - Fix MSVC build in `pipe.h` where `DWORD` is not cast to proper return type (mlc-ai/relax#306); - Fix MSVC build warnings on not recognizing "#pragma GCC" (mlc-ai/relax#307); - Fix NVCC build warnings where it fails to infer if "[[noreturn]]" actually does not return (mlc-ai/relax#308); - Fix ROCM/Vulkan backend which fails compilation for operators like group GEMM, paged attention, etc. (apache#16404, apache#16405) Co-authored-by: Bohan Hou <bohanhou@andrew.cmu.edu> Co-authored-by: Lesheng Jin <leshenj15@gmail.com>
junrushao
force-pushed
the
bugfix/2024-01-16/fix-cd
branch
from
7471cd1 to
9cb8e28
Compare
tqchen
approved these changes
Jan 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upstreams a few commits that recovers the unity branch from broken wheel packages. It includes the following changes:
pipe.hwhereDWORDis not cast to proper return type ([Bugfix] fix win pipe.h mlc-ai/relax#306);