[SVE] Add vscale builtin#16484
Merged
Hzfengsy merged 2 commits intoapache:mainfrom Jan 31, 2024
Merged
Conversation
12 tasks
Contributor
Author
zhangwm-pt
approved these changes
Jan 30, 2024
lhutton1
approved these changes
Jan 30, 2024
Contributor
lhutton1
left a comment
There was a problem hiding this comment.
I had one small suggestion, but otherwise looks good to me!
also cc @tqchen @cbalint13 @Lunderberg @kparzysz-quic
cbalint13
reviewed
Jan 30, 2024
cbalint13
approved these changes
Jan 30, 2024
Contributor
cbalint13
left a comment
There was a problem hiding this comment.
This looks good to me.
Add a vscale builtin and lowering to `llvm.vscale`. This will be used in subsequent patches for expressing scalable vectors in TIR. Co-authored-by: Luke Hutton <luke.hutton@arm.com> Co-authored-by: Neil Hickey <neil.hickey@arm.com>
Change-Id: I5b364a8b50c8622d21d3d6d30b9d44a56e0418db
98a3eb3 to
f6a1660
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
vscalebuiltin and lowering tollvm.vscale. This will be used in subsequent patches for expressing scalable vectors in TIR.