-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[Unity][Parser] Check well-formedness in the parser #16569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
slyubomirsky
merged 58 commits into
apache:main
from
slyubomirsky:parser-check-well-formed
Mar 21, 2024
Merged
Changes from 1 commit
Commits
Show all changes
58 commits
Select commit
Hold shift + click to select a range
6c880b6
Check well-formedness in the parser
slyubomirsky dbf64d0
Correct packed funcs in NN frontend
slyubomirsky 471148c
Support the check_well_formed optional argument to I.ir_module
slyubomirsky ca0ce7a
Also check well-formedness in TIR
slyubomirsky 76d79a6
Enable normalization for individual Relax functions and PrimFuncs
slyubomirsky cefdb7e
Use the error raised by the TIR well-formed checker for the message
slyubomirsky 3177880
Fix tvmscript test failures
slyubomirsky 4f9f97a
Whitespace
slyubomirsky 019a85b
Fix errors in verify_well_formed test
slyubomirsky ab2f2bd
Include a more helpful error message
slyubomirsky a6db5fa
Fix TIR test failures
slyubomirsky 2048e60
Address well-formed failures in test_tir_specialize
slyubomirsky 831f8f2
Correct well-formedness error in test_tir_analysis_oob
slyubomirsky e6d5f00
Correct further well-formedness failures
slyubomirsky 3070b18
Remove __tvm_meta__ from test case to avoid parsing error
slyubomirsky 5c7aec3
Avoid circular import in entryy.py
slyubomirsky 87426d3
Formatting fixes
slyubomirsky 7e299e9
lint fix
slyubomirsky b8616f2
Add pylint exceptions
slyubomirsky cb114e4
Fix whitespace
slyubomirsky ea357bb
Fix more failed test cases
slyubomirsky 5d6de7d
Catch inappropriate use of decl_function instead of segfaulting
slyubomirsky 574677a
Fix test_lower.py
slyubomirsky 08819aa
Mark purity in test_relax_2d_buffer_allocation.py
slyubomirsky f93c406
Mark purity in test_dma_builtin.py
slyubomirsky 299abbc
Remove __tvm_meta___ from test_tir_usmp_analysis_extract_bufferinfo.py
slyubomirsky fda20a3
Suppress well-formed check in test_tir_transform_convert_blocks_to_op…
slyubomirsky 8b9506d
Remove __tvm_meta__ in test_tir_usmp_algo.py
slyubomirsky 4944c3a
Remove __tvm_meta__ from more USMP tests
slyubomirsky 7889711
Fix incorrect var in test_tir_transform_storage_flatten.py
slyubomirsky e11cf8c
Remove all remaining instances of __tvm_meta__
slyubomirsky e35499d
Fix purity error in test_dataflow_pattern.py
slyubomirsky 261e3eb
Fix purity error in test_ast_printer
slyubomirsky 6cc354c
Fix test_arith_domain_touched example
slyubomirsky 355aedf
Okay to set check_well_formed to True in test_tir_analysis_identify_m…
slyubomirsky f1b6dcb
Define variable in test_tir_analysis_oob
slyubomirsky d9dbeb5
Typo fix
slyubomirsky 0ca4698
Add explanatory comment to test case
slyubomirsky 8af392d
Define the undefined vars in test_tir_transform_common_subexpr_elim
slyubomirsky 07c8819
Exception no longer necessary in test_tir_transform_inject_rolling_bu…
slyubomirsky ae8001c
Remove unnecessary check exemption in test_tir_transform_convert_ssa
slyubomirsky b373a4f
Avoid checking exemption in test_inject_ptx_ldg32
slyubomirsky 785394d
Note special case in test_distributed_transform_propagate_sharding
slyubomirsky 571cf47
Exempt well-formed error in dlight/test_benchmark
slyubomirsky aff00de
Exempt well-formedness errors in test_ethosu/, mostly uninitialized vars
slyubomirsky a8e7415
Whitespace
slyubomirsky f772190
Include non-CUDA GPUs in IsScheduledOnGPU
slyubomirsky f82ca07
Fix thread binding bug by changing thread binding var dtype
slyubomirsky 2b7c4ca
Include overrides in test_runtime_builtin_paged_attention_kv_cache.py
slyubomirsky d254177
add exemptions in test_ethosu/test_replace_conv2d
slyubomirsky 3247cb5
Add more ethosu exemptions
slyubomirsky 9cd556d
More exemptions for ethosu tests
slyubomirsky 1800188
Remove unused reference
slyubomirsky c54267b
Indicate purity in test_transform_rewrite_cuda_graph
slyubomirsky 3684fd3
Indicate purity in test_transform_normalize
slyubomirsky e77ef6e
Reorder MergeSharedMemoryAllocations in GPU codegen
slyubomirsky c8fb78c
Add target parameter for FP8StorageLegalize and FP8ComputeLegalize
slyubomirsky 3395808
Don't re-import Target in tvm/tir/transform/transform.py
slyubomirsky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Address well-formed failures in test_tir_specialize
- Loading branch information
commit 2048e60194336e29add2a6f7145c15fa043610bb
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This error was especially baffling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Lunderberg do you think anything needs to be done about this case? Is it legitimate to have a well-formedness error here?