Skip to content

Enable Shared Function in LiftTransformParam Pass #16717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vinx13 merged 12 commits into from
Mar 19, 2024
Merged

Enable Shared Function in LiftTransformParam Pass #16717

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e76706d
[WIP] LiftTransformParams for multiple functions
vinx13 Mar 13, 2024
a83d04a
pass test
vinx13 Mar 13, 2024
785ad8c
[In-Progress] Define desired behavior for shared LiftTransformParams
Lunderberg Mar 8, 2024
3e45b20
[TIR] Implemented shared lift transform params
vinx13 Mar 13, 2024
7bde992
Comments & skip test.
zxybazh Mar 14, 2024
a5bbfcc
Linting.
zxybazh Mar 14, 2024
085c0a6
Avoid c++20 feature to pass CI.
zxybazh Mar 14, 2024
46896a6
Remove unused code.
zxybazh Mar 14, 2024
1b006ee
Fix interface as suggested.
zxybazh Mar 18, 2024
a516349
Fix docs.
zxybazh Mar 18, 2024
0ae628e
Fix interface as suggested.
zxybazh Mar 18, 2024
dca7667
Move code for readability.
zxybazh Mar 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Avoid c++20 feature to pass CI.
  • Loading branch information
@zxybazh
zxybazh committed Mar 14, 2024
commit 085c0a63fea620be33b525df3d55994c9db0d3f0
12 changes: 7 additions & 5 deletions src/relax/transform/lift_transform_params.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,10 +578,12 @@ class GlobalLiftableBindingCollector : public BaseLiftableBindingCollector {
Array<Var> params(functions[0]->params.begin() +
functions[0]->GetAttr<Integer>(attr::kNumInput).value()->value,
functions[0]->params.end());
GlobalCollectInfo info{.orig_functions = functions,
.params = std::move(params),
.var_remap = var_remap,
.tir_var_remap = tir_var_remap};
// todo(@tvm-team): use c++20 designated initializers when windows CI supports it
GlobalCollectInfo info = GlobalCollectInfo();
info.orig_functions = functions;
info.params = std::move(params);
info.var_remap = var_remap;
info.tir_var_remap = tir_var_remap;
// Find shared bindings among transform_params. Re-compute var_remap based on the shared
// bindings as collector.var_remap_ may contain invalid mappings.
for (const auto& unified_binding : collector.unified_bindings_) {
Expand Down Expand Up @@ -641,7 +643,7 @@ class GlobalLiftableBindingCollector : public BaseLiftableBindingCollector {
// defined in var_remap_.
std::unordered_map<Expr, std::vector<Binding>, StructuralHash, StructuralEqual>
original_bindings_;
};
}; // namespace

GlobalCollectInfo MakeGlobalLiftPlan(const IRModule& mod,
const std::vector<Function>& target_functions) {
Expand Down