[Bugfix][TIR] Fix cache_read update buffer region#16742
Merged
tqchen merged 1 commit intoapache:mainfrom Mar 20, 2024
Merged
Conversation
Hzfengsy
approved these changes
Mar 19, 2024
97b0083 to
534ff63
Compare
Prior to this commit, cache_read primitive may not update the block reads buffer region properly when there is a nested buffer access. This commit fix this bug and add a cache_read unit test.
534ff63 to
41a2761
Compare
thaisacs
pushed a commit
to thaisacs/tvm
that referenced
this pull request
Apr 3, 2024
Prior to this commit, cache_read primitive may not update the block reads buffer region properly when there is a nested buffer access. This commit fix this bug and add a cache_read unit test. Co-authored-by: qsqqsqqsq-intellif <qing.siqi@intellif.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit, cache_read primitive may not update the block reads buffer region properly when there is a nested buffer access.
T.reads(A[B[v_ax0], v_ax1])should be updated asT.reads(A[B_global[v_ax0], v_ax1])cc @Hzfengsy