Revert "[SLM] Allow modules to define pre-processing of weights"#16777
Merged
MasterJH5574 merged 1 commit intomainfrom Mar 25, 2024
Merged
Conversation
…)" This reverts commit 1cccc3b.
Contributor
|
@tqchen Can you add a unit test demonstrating the behavior to be retained? Is it only for the string names of symbolic variables, as mentioned in this comment? |
Member
Author
|
Likely i think it would be primarily two parameters with same |
Member
Author
|
Happy to also test followup redos of the PR in case we miss other cases |
Contributor
|
I replied with a test to the other PR before noticing the on-going thread here. #16757 (comment) @tqchen so could you help pasting it into |
MasterJH5574
approved these changes
Mar 25, 2024
Contributor
|
Merged without the unit test to keep the reversion standalone. Let's add the test case separately. Thank you folks! |
Contributor
|
I have a parametrized version of the test case, along with testing for cases beyond |
Lunderberg
added a commit
to Lunderberg/tvm
that referenced
this pull request
Mar 25, 2024
Follow-up to apache#16777, add unit tests demonstrating desired behavior.
Lunderberg
added a commit
to Lunderberg/tvm
that referenced
this pull request
Mar 25, 2024
Prior to this commit, the weights used by `nn.Module` instances were required to be `nn.Parameter` instances. This commit allows the weights to instead be `nn.Tensor` instances, defined in terms of other `nn.Parameter` weights. This allows a model to define both the original weights that would be present in an external checkpoint (e.g. a Pytorch or Safetensors file), and the pre-processing that should be performed on those weights. This is a re-implementation of apache#16757, which was reverted in apache#16777. The re-implementation preserves the handling of dynamic shapes specified as python strings, enabling the test cases that were added in apache#16784.
Lunderberg
added a commit
that referenced
this pull request
Mar 29, 2024
* [SLM] Add unit tests for SLM to Relax exporter Follow-up to #16777, add unit tests demonstrating desired behavior. * Updated docstrings based on review comment
thaisacs
pushed a commit
to thaisacs/tvm
that referenced
this pull request
Apr 3, 2024
…che#16777) Revert "[SLM] Allow modules to define pre-processing of weights (apache#16757)" This reverts commit 1cccc3b.
thaisacs
pushed a commit
to thaisacs/tvm
that referenced
this pull request
Apr 3, 2024
* [SLM] Add unit tests for SLM to Relax exporter Follow-up to apache#16777, add unit tests demonstrating desired behavior. * Updated docstrings based on review comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #16757