[LLVM] Fix compilation failure due to minor change#16812
Merged
quic-sanirudh merged 1 commit intoapache:mainfrom Mar 30, 2024
Merged
[LLVM] Fix compilation failure due to minor change#16812quic-sanirudh merged 1 commit intoapache:mainfrom
quic-sanirudh merged 1 commit intoapache:mainfrom
Conversation
This is just a minor fix where the recent [PR apache#16425](apache#16425) seems to have missed this change for LLVM 18 and above, and so we're running into a compilaion failure.
Contributor
Author
lhutton1
approved these changes
Mar 28, 2024
Contributor
lhutton1
left a comment
lhutton1
left a comment
There was a problem hiding this comment.
Apologies for missing this previously, thanks for the fix @quic-sanirudh!
Contributor
|
I also missed this, I only focused thoroughly on But never mind, LLVM 19 is on the horizon for even newer fixes (joking of course). |
Contributor
Author
|
@tvm-bot rerun |
thaisacs
pushed a commit
to thaisacs/tvm
that referenced
this pull request
Apr 3, 2024
This is just a minor fix where the recent [PR apache#16425](apache#16425) seems to have missed this change for LLVM 18 and above, and so we're running into a compilaion failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a minor fix where the recent PR #16425 seems to have missed this change for LLVM 18 and above case, and so we're running into a compilaion failure.