[Web] Allow custom bc files in emcc making#16825
Merged
MasterJH5574 merged 2 commits intoapache:mainfrom Apr 1, 2024
Merged
Conversation
Member
Author
|
cc @tqchen |
tqchen
reviewed
Mar 31, 2024
tqchen
approved these changes
Mar 31, 2024
thaisacs
pushed a commit
to thaisacs/tvm
that referenced
this pull request
Apr 3, 2024
When running `emcc` for building a wasm, we currently only pass in libraries `wasm_runtime.bc`, `tvmjs_support.bc`, and `webgpu_runtime.bc`. This PR allows users to optionally pass in their own `.bc` files by adding a kwarg `libs`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running
emccfor building a wasm, we currently only pass in librarieswasm_runtime.bc,tvmjs_support.bc, andwebgpu_runtime.bc. This PR allows users to optionally pass in their own.bcfiles by adding a kwarglibs.