Overriding the StructuralEqual() for easy usage#16908
Merged
quic-sanirudh merged 4 commits intoapache:mainfrom Apr 30, 2024
Merged
Overriding the StructuralEqual() for easy usage#16908quic-sanirudh merged 4 commits intoapache:mainfrom
quic-sanirudh merged 4 commits intoapache:mainfrom
Conversation
quic-sanirudh
approved these changes
Apr 20, 2024
Contributor
quic-sanirudh
left a comment
quic-sanirudh
left a comment
There was a problem hiding this comment.
LGTM, but please fix the lint errors.
Contributor
|
@tvm-bot rerun |
sdalvi-quic
force-pushed
the
sdalvi/StructuralEq_override
branch
from
bd2af20 to
b9b452b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Override the StrucutralEqual operator () to ensure easy usage of the function.
@jverma-quic and @quic-sanirudh can you please take a look.