[Relax] Allow PrimValue as index in relax.op.take#16940
Merged
Lunderberg merged 3 commits intoapache:mainfrom Apr 28, 2024
Merged
[Relax] Allow PrimValue as index in relax.op.take#16940Lunderberg merged 3 commits intoapache:mainfrom
Lunderberg merged 3 commits intoapache:mainfrom
Conversation
Prior to this commit, the `relax.op.take` only allowed tensors as the `indices` argument. This commit extends `R.take` to also allow the index to be a `relax::PrimValue`.
masahi
approved these changes
Apr 27, 2024
yongwww
approved these changes
Apr 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the
relax.op.takeonly allowed tensors as theindicesargument. This commit extendsR.taketo also allow the index to be arelax::PrimValue.