[Unity][BYOC] Use arith.Analyzer to check batch equality of matmul in cublas#16982
Merged
tqchen merged 3 commits intoapache:mainfrom May 9, 2024
Merged
[Unity][BYOC] Use arith.Analyzer to check batch equality of matmul in cublas#16982tqchen merged 3 commits intoapache:mainfrom
tqchen merged 3 commits intoapache:mainfrom
Conversation
Contributor
Author
|
cc: @MasterJH5574 |
MasterJH5574
approved these changes
May 8, 2024
Contributor
MasterJH5574
left a comment
There was a problem hiding this comment.
Looks good, thanks!
tqchen
approved these changes
May 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For workloads with a mixture of symbolic shape and concrete shape as batch sizes, we cannot directly use
int()to obtain the batch size. Instead, we can usearith.Analyzerto check equality.For example: