[TIR] Fix Bug in VectorizeLoop #17039
Merged
ekalda merged 2 commits intoapache:mainfrom May 30, 2024
Merged
Conversation
This PR fixes a bug in vectorize loop introduced related to recent change. The visit to condition can write need scalarize to true then the followup visit to then case can trigger an ICHECK. The visit to let value can also write need scalarize flag in which case we need to immediately scalarize.
lhutton1
approved these changes
May 29, 2024
Contributor
lhutton1
left a comment
lhutton1
left a comment
There was a problem hiding this comment.
Thanks for the fix, apologies for missing it previously!
Member
|
@tvm-bot rerun |
Member
|
@tvm-bot rerun |
Contributor
|
Thanks @tqchen and @CharlieFRuan for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in vectorize loop introduced related to #16966
The visit to condition can write need scalarize to true then the followup visit to then case can trigger an ICHECK.
The visit to let value can also write need scalarize flag in which case we need to immediately scalarize.