[UnitTests] Use tvm.ir.assert_structural_equal whenever possible#17092
Merged
Lunderberg merged 2 commits intoapache:mainfrom Jun 14, 2024
Merged
[UnitTests] Use tvm.ir.assert_structural_equal whenever possible#17092Lunderberg merged 2 commits intoapache:mainfrom
Lunderberg merged 2 commits intoapache:mainfrom
Conversation
Prior to commit, many unit tests were implemented as `assert tvm.ir.structural_equal(output, expected)`. While this is correct, it doesn't provide much information when the test fails. The `tvm.ir.assert_structural_equal` method performs the equivalent check, but displays the exact location where a mismatch occurs. This commit replaces all use of `assert tvm.ir.structural_equal` with `tvm.ir.assert_structural_equal`.
yongwww
approved these changes
Jun 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to commit, many unit tests were implemented as
assert tvm.ir.structural_equal(output, expected). While this is correct, it doesn't provide much information when the test fails. Thetvm.ir.assert_structural_equalmethod performs the equivalent check, but displays the exact location where a mismatch occurs.This commit replaces all use of
assert tvm.ir.structural_equalwithtvm.ir.assert_structural_equal.