[CI] Remove lint step from unity/pr-head step#17155
Merged
vinx13 merged 2 commits intoapache:mainfrom Jul 16, 2024
Merged
Conversation
This step should only be performed as part of the `lint/pr-head` CI step. It was included as part of the unity-specific CI steps prior to merging of unity into main. It is no longer necessary as part of `unity/pr-head`.
Lunderberg
force-pushed
the
ci_remove_lint_step_from_unity
branch
from
fd582ee to
374ad4e
Compare
Contributor
Author
|
@tvm-bot rerun |
quic-sanirudh
approved these changes
Jul 16, 2024
Contributor
quic-sanirudh
left a comment
quic-sanirudh
left a comment
There was a problem hiding this comment.
This will definitely help, thanks.
Not strictly related to this PR, but as a general question, do we need to keep the unity/pr-head separate anymore? I see that it builds and runs some cpu and gpu tests, couldn't we just move them to the cpu and gpu heads and just remove this. It might help avoid building for cpu and gpu in 2 separate builds, and avoid running some of these tests multiple times?
Contributor
Author
I don’t know of any reason why they’d need to remain separate, and that would definitely help make the test summaries more readable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This step should only be performed as part of the
lint/pr-headCI step. It was included as part of the unity-specific CI steps prior to merging of unity into main. It is no longer necessary as part ofunity/pr-head.