[FFI][Runtime] Use TVMValue::v_int64 to represent boolean values#17240
Merged
tqchen merged 2 commits intoapache:mainfrom Aug 22, 2024
Merged
[FFI][Runtime] Use TVMValue::v_int64 to represent boolean values#17240tqchen merged 2 commits intoapache:mainfrom
tqchen merged 2 commits intoapache:mainfrom
Conversation
This is a follow-up to apache#16183, which added handling of boolean values in the TVM FFI. The initial implementation added both a new type code (`kTVMArgBool`) and a new `TVMValue::v_bool` variant. This commit removes the `TVMValue::v_bool` variant, since the `kTVMArgBool` type code is sufficient to handle boolean arguments. Removing the `TVMValue::v_bool` variant also makes all `TVMValue` variants be 64-bit (assuming a 64-bit CPU). This can simplify debugging in some cases, since it prevents partial values from inactive variants from being present in memory.
Lunderberg
force-pushed
the
ffi_use_int64_variant_to_represent_bool
branch
from
d2ac722 to
5ee4fb3
Compare
Contributor
Author
Contributor
Author
|
Fixed last two failing unit tests, since |
tqchen
approved these changes
Aug 22, 2024
MasterJH5574
added a commit
to MasterJH5574/tvm
that referenced
this pull request
Aug 29, 2024
This PR fixes the conversion of boolean value for Java, following the changes in apache#17240
MasterJH5574
added a commit
to mlc-ai/relax
that referenced
this pull request
Aug 29, 2024
This PR fixes the conversion of boolean value for Java, following the changes in apache/tvm#17240
MasterJH5574
added a commit
to MasterJH5574/tvm
that referenced
this pull request
Aug 29, 2024
This PR fixes the conversion of boolean value for Java, following the changes in apache#17240
MasterJH5574
added a commit
to MasterJH5574/tvm
that referenced
this pull request
Aug 29, 2024
This PR fixes the conversion of boolean value for Java, following the changes in apache#17240
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #16183, which added handling of boolean values in the TVM FFI. The initial implementation added both a new type code (
kTVMArgBool) and a newTVMValue::v_boolvariant. This commit removes theTVMValue::v_boolvariant, since thekTVMArgBooltype code is sufficient to handle boolean arguments.Removing the
TVMValue::v_boolvariant also makes allTVMValuevariants be 64-bit (assuming a 64-bit CPU). This can simplify debugging in some cases, since it prevents partial values from inactive variants from being present in memory.