[Fix][Relax] Fix dangling reference in GetTargetFunctions()#17950
Merged
cbalint13 merged 1 commit intoapache:mainfrom May 13, 2025
Merged
[Fix][Relax] Fix dangling reference in GetTargetFunctions()#17950cbalint13 merged 1 commit intoapache:mainfrom
cbalint13 merged 1 commit intoapache:mainfrom
Conversation
cbalint13
approved these changes
May 13, 2025
Contributor
cbalint13
left a comment
There was a problem hiding this comment.
Thank you for this fix !
ShiboXing
pushed a commit
to ShiboXing/tvm
that referenced
this pull request
Aug 10, 2025
…7950) This patch fixes a dangling reference issue that can be reproduced locally on macOS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes a dangling reference issue that can be reproduced locally on macOS.
This root cause is that the rvalue returned by
.as<>()is destroyed at the end of the full-expression, before the for loop actually begins.A minimal example that demonstrates this issue: https://godbolt.org/z/99vWrK1rq
Below is the call stack for reference.
Thanks,