Skip to content

[Relax][PyTorch] Unify tests using shared tvm.testing.assert_allclose#18522

Merged
tlopex merged 2 commits intoapache:mainfrom
guan404ming:unify-assertion
Nov 29, 2025
Merged

[Relax][PyTorch] Unify tests using shared tvm.testing.assert_allclose#18522
tlopex merged 2 commits intoapache:mainfrom
guan404ming:unify-assertion

Conversation

@guan404ming
Copy link
Copy Markdown
Member

@guan404ming guan404ming commented Nov 28, 2025

Why

We have the shared assert_allclose func in tests and to use it in every tests could help persist consistency

@guan404ming guan404ming changed the title [Relax][PyTorch] Replace numpy testing assertions with TVM testing assertions [Relax][PyTorch] Unify tests using shared assert_allclose Nov 28, 2025
@guan404ming guan404ming changed the title [Relax][PyTorch] Unify tests using shared assert_allclose [Relax][PyTorch] Unify tests using shared tvm.testing.assert_allclose Nov 28, 2025
@guan404ming guan404ming marked this pull request as ready for review November 28, 2025 14:35
@guan404ming
Copy link
Copy Markdown
Member Author

cc @mshr-h @tlopex

@mshr-h mshr-h requested a review from tlopex November 29, 2025 05:04
Copy link
Copy Markdown
Member

@tlopex tlopex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@tlopex tlopex merged commit acda952 into apache:main Nov 29, 2025
14 checks passed
@guan404ming guan404ming deleted the unify-assertion branch November 29, 2025 07:37
@guan404ming
Copy link
Copy Markdown
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants