[Docs] Improve static shape tuning parameter configuration (follow-up to commit c71aefc)#18545
Conversation
ConvolutedDog
commented
Dec 4, 2025
- Expose max_trials_per_task parameter to static_shape_tuning_pipeline
- Adjust default TOTAL_TRIALS from 8000 to 80 for tutorial demonstration purposes
- Add documentation for tuning parameters in tutorial, clarifying relationship between MAX_TRIALS_PER_TASK and TOTAL_TRIALS
… to commit c71aefc) - Add max_trials_per_task parameter to static_shape_tuning_pipeline - Adjust default TOTAL_TRIALS from 8000 to 80 for tutorial demonstration purposes - Add documentation for tuning parameters in tutorial, clarifying relationship between MAX_TRIALS_PER_TASK and TOTAL_TRIALS
Summary of ChangesHello @ConvolutedDog, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the configuration of static shape tuning parameters within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request exposes the max_trials_per_task parameter to the static_shape_tuning_pipeline and updates the corresponding tutorial. The changes are a good improvement for controlling the tuning process. However, I've found a critical bug in the implementation that will cause a TypeError when max_trials_per_task is not provided. Additionally, I've pointed out a couple of areas in the new documentation and comments that could be clarified to avoid user confusion. Please see my detailed comments.
cbalint13
left a comment
There was a problem hiding this comment.
LGTM, but would 512/16 be more resonable ?
|
@tvm-bot rerun |
|
@cbalint13 @mshr-h Could you please take another look at the latest commit? Thanks~ |
tlopex
left a comment
There was a problem hiding this comment.
It looks great to me! Thank you
|
Thank you for the enhancement ! |