Skip to content

[Relax][PyTorch] Unify dtype used in conv2d tests#18553

Merged
tlopex merged 1 commit intoapache:mainfrom
guan404ming:update-conv2d-test
Dec 6, 2025
Merged

[Relax][PyTorch] Unify dtype used in conv2d tests#18553
tlopex merged 1 commit intoapache:mainfrom
guan404ming:update-conv2d-test

Conversation

@guan404ming
Copy link
Copy Markdown
Member

@guan404ming guan404ming commented Dec 6, 2025

Why

  • resolve todo in test_op_gradient_numeric.py by unifying the dtype used in conv2d related test
  • use float32 with reduced range [0, 3] to maintain numerical precision for gradient checking

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @guan404ming, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the gradient numeric tests for conv2d, max_pool2d, and avg_pool2d operations by standardizing the input data type to float32. This change addresses a previous TODO comment, aiming to prevent potential precision issues during gradient checks and ensure consistency across related tests. The update also includes a minor adjustment to the range of randomly generated test data.

Highlights

  • Data Type Unification: Updated the gradient numeric tests for conv2d, max_pool2d, and avg_pool2d to consistently use float32 for input data, addressing potential precision issues.
  • TODO Resolution: Resolved a long-standing TODO comment in test_op_gradient_numeric.py that called for unifying the data types used in conv2d related tests.
  • Random Data Range Adjustment: Modified the np.random.uniform range for generating test data from (0, 16) to (0, 3) across the affected convolutional and pooling tests.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@guan404ming guan404ming changed the title Update to use float32 in conv2d, max_pool2d, and avg_pool2d tests [Relax][PyTorch] Unify dtype used in conv2d tests Dec 6, 2025
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a nice improvement that resolves a TODO by updating several neural network operator gradient tests (conv2d, max_pool2d, avg_pool2d) to use float32 instead of float64. This change enhances consistency across the test suite and is better for checking correctness, avoiding potential precision issues with float64. The accompanying change to unify the random data generation range is also a good cleanup. The changes are correct and well-contained.

@guan404ming guan404ming marked this pull request as ready for review December 6, 2025 03:53
@guan404ming
Copy link
Copy Markdown
Member Author

cc @tlopex @mshr-h

@tlopex tlopex merged commit 5138efc into apache:main Dec 6, 2025
16 checks passed
@guan404ming guan404ming deleted the update-conv2d-test branch December 6, 2025 06:18
@guan404ming
Copy link
Copy Markdown
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants