Skip to content

[Relax] Add edge padding mode#18558

Merged
cbalint13 merged 1 commit intoapache:mainfrom
guan404ming:edge-pad
Dec 9, 2025
Merged

[Relax] Add edge padding mode#18558
cbalint13 merged 1 commit intoapache:mainfrom
guan404ming:edge-pad

Conversation

@guan404ming
Copy link
Copy Markdown
Member

Why

resolve todo in python/tvm/relax/frontend/common.py

How

  • add edge padding mode
  • add auto pad test

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @guan404ming, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the autopad function in the Relax frontend by introducing support for the 'edge' padding mode. This resolves a known limitation and expands the functionality for handling tensor padding operations. The changes also include the addition of new test cases to validate the behavior of all supported padding modes, ensuring the reliability of the updated functionality.

Highlights

  • Edge Padding Mode Implementation: The 'edge' padding mode has been fully implemented within the autopad utility function, resolving a previously existing TODO and NotImplementedError.
  • Comprehensive Test Coverage: New tests have been added for the autopad function, specifically covering the 'constant', 'edge', and 'reflect' padding modes to ensure correctness and robustness.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly implements the 'edge' padding mode for the autopad utility, resolving a TODO in the process. The implementation correctly uses topi.nn.replicate_pad. Furthermore, you've added a comprehensive new test class for autopad that covers not only the new 'edge' mode but also existing 'constant' and 'reflect' modes. This significantly improves test coverage and confidence in this utility. The code is clean, correct, and well-tested. Great work!

@guan404ming guan404ming marked this pull request as ready for review December 9, 2025 05:14
@guan404ming
Copy link
Copy Markdown
Member Author

cc @tlopex @mshr-h

Copy link
Copy Markdown
Contributor

@cbalint13 cbalint13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

Thanks @guan404ming !

@cbalint13 cbalint13 merged commit 04f06b5 into apache:main Dec 9, 2025
15 checks passed
@guan404ming
Copy link
Copy Markdown
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants