[CI] Remove i386 and Hexagon from CI pipeline (2)#18749
Conversation
Summary of ChangesHello @mshr-h, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request continues the ongoing effort to streamline the CI pipeline by discontinuing support for specific architectures, namely i386 and Hexagon. This change aims to reduce maintenance overhead and focus resources on more actively used platforms, aligning with the broader initiative to optimize CI processes. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request aims to remove i386 and Hexagon from the CI pipeline by deleting their image definitions from docker-images.ini. However, this change is incomplete and will break the CI. Several other files in the repository still reference these images and expect them to be defined here, which will cause the build to fail. All related changes to remove i386 and Hexagon support should be done atomically in a single pull request to ensure the main branch remains stable.
I am having trouble creating individual review comments. Click here to see my feedback.
ci/jenkins/docker-images.ini (23-24)
Removing these docker image definitions is an incomplete change that will break the CI pipeline. These images are still referenced in other files, which will cause ci/scripts/jenkins/determine_docker_images.py to fail when it can't find these keys in this file.
To correctly remove i386 and hexagon support, all references should be removed across the repository in an atomic change. This includes, but is not limited to:
ci/jenkins/data.py- Jenkinsfile templates and generated files for hexagon and i386.
- Calls to
determine_docker_images.pyin various jenkinsfiles.
Please group all related changes into a single PR to avoid breaking the main branch.
f48ceea to
804b494
Compare
d39334a to
e83b45d
Compare
|
@tvm-bot rerun |
Part of #18682