-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[WebGPU] Add gating logic for subgroup shuffle primitives #18823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
097d05f
WebGPU: gate subgroup ops via target parser thread_warp_size
ksgr5566 f119bbd
merge main
ksgr5566 b1e3688
merge main
ksgr5566 07d011c
updates based on latest merge
ksgr5566 3298e94
Merge remote-tracking branch 'origin/main' into webgpu-subgroup-test
ksgr5566 b1139a9
Added tests for warp reduce - subgroup enabled webgpu
ksgr5566 e9697fe
Lint errors fixed
ksgr5566 d95827a
[WebGPU] Add unit tests for subgroup warp reduction and fix uint32 ca…
ksgr5566 397ac1b
[Webgpu] Segment fault bug fix
ksgr5566 89d6142
[WebGPU] Add missing JSON implementation includes to WASM unity build
ksgr5566 9a3edc9
Merge remote-tracking branch 'origin' into webgpu-subgroup-test
ksgr5566 4fb4cce
Merge remote-tracking branch 'origin/main' into webgpu-subgroup-test
ksgr5566 3c2ab40
Merge remote-tracking branch 'origin/main' into webgpu-subgroup-test
ksgr5566 53409cb
[WebGPU] Address PR review feedback for subgroup lowering
ksgr5566 a69af46
Merge remote-tracking branch 'origin/main' into webgpu-subgroup-test
ksgr5566 17e9e67
[WebGPU] Resolve comments
ksgr5566 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -742,11 +742,11 @@ class ThreadAllreduceBuilder final : public StmtExprMutator { | |||||||||||||||||||||||||||||||
| bool IsWarpReduction(const std::vector<DataType>& types, int group_extent, int reduce_extent, | ||||||||||||||||||||||||||||||||
| int contiguous_reduce_extent) { | ||||||||||||||||||||||||||||||||
| if ((target_->kind->name != "cuda") && (target_->kind->name != "rocm") && | ||||||||||||||||||||||||||||||||
| (target_->kind->name != "metal")) { | ||||||||||||||||||||||||||||||||
| (target_->kind->name != "metal") && (target_->kind->name != "webgpu")) { | ||||||||||||||||||||||||||||||||
| return false; | ||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||
| need_warp_shuffle_mask_ = target_->kind->name != "metal"; | ||||||||||||||||||||||||||||||||
| need_warp_shuffle_mask_ = target_->kind->name != "metal" && target_->kind->name != "webgpu"; | ||||||||||||||||||||||||||||||||
|
Comment on lines
744
to
+749
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To improve maintainability, consider using
Suggested change
|
||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||
| // rocm only supports 32 bit operands for shuffling at the moment | ||||||||||||||||||||||||||||||||
| if ((target_->kind->name == "rocm") && | ||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.