Skip to content

Conditions updated to cover better user scenarios #4951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tqchen merged 7 commits into from
Mar 5, 2020
Merged

Conditions updated to cover better user scenarios #4951

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a01ce2c
Conditions updated to cover better user scenarios
Feb 27, 2020
f93a688
[1] New test case added
Feb 29, 2020
af9c68c
[2] New test case added
Feb 29, 2020
742bec5
[3] Proper variable name used
Feb 29, 2020
d0c53b0
[4] Review Comments handled
Mar 1, 2020
e5522cf
[5] Review comments handled
Mar 2, 2020
4b7909a
[6] Review comments handled
Mar 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/relay/ir/alpha_equal.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,14 +50,14 @@ class AlphaEqualHandler:
* \return The comparison result.
*/
bool Equal(const ObjectRef& lhs, const ObjectRef& rhs) {
if (lhs.same_as(rhs)) return true;
if (!lhs.defined() || !rhs.defined()) return false;
if (lhs->IsInstance<TypeNode>()) {
if (!rhs->IsInstance<TypeNode>()) return false;
if (lhs.same_as(rhs)) return true;
if (lhs->IsInstance<TypeNode>() || rhs->IsInstance<TypeNode>()) {
if (!rhs->IsInstance<TypeNode>() || !lhs->IsInstance<TypeNode>()) return false;
return TypeEqual(Downcast<Type>(lhs), Downcast<Type>(rhs));
}
if (lhs->IsInstance<ExprNode>()) {
if (!rhs->IsInstance<ExprNode>()) return false;
if (lhs->IsInstance<ExprNode>() || rhs->IsInstance<ExprNode>()) {
if (!rhs->IsInstance<ExprNode>() || !lhs->IsInstance<ExprNode>()) return false;
return ExprEqual(Downcast<Expr>(lhs), Downcast<Expr>(rhs));
}
if (const auto lhsm = lhs.as<IRModuleNode>()) {
Expand Down