Skip to content

[TVMC] Python Scripting Init Files#7698

Merged
jwfromm merged 7 commits intoapache:mainfrom
CircleSpin:init_files
Mar 24, 2021
Merged

[TVMC] Python Scripting Init Files#7698
jwfromm merged 7 commits intoapache:mainfrom
CircleSpin:init_files

Conversation

@CircleSpin
Copy link
Copy Markdown
Contributor

@CircleSpin CircleSpin commented Mar 18, 2021

This PR adds to two init files to make tvmc cleaner for running python scripts. For example, instead of running tvmc.runner.run_module() you can now run tvmc.run()

@CircleSpin
Copy link
Copy Markdown
Contributor Author

CircleSpin commented Mar 18, 2021

@jwfromm @leandron @mdw-octoml

mdw-octoml
mdw-octoml approved these changes Mar 18, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@mdw-octoml mdw-octoml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread python/tvm/driver/tvmc/__init__.py Outdated
leandron
leandron reviewed Mar 18, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@leandron leandron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the use case here that TVMC is used as an API within python scripts? it look OK to me, since it is part of TVM.

Can we think of a few test cases to add, to cover this new entry-point for tvmc as API?

cc @comaniac

@jwfromm
Copy link
Copy Markdown
Contributor

jwfromm commented Mar 19, 2021

@leandron yeah we think TVMC has an excellent set of utilities to make it a simplified python API for new users, kind of like keras. You did an awesome job packing tons of functionality into a few key function calls, but some of them need some small changes to better accommodate access from Python. @CircleSpin is working on making these changes.

@CircleSpin
Copy link
Copy Markdown
Contributor Author

CircleSpin commented Mar 19, 2021

I've modified the test files so that they use new the importing syntax. Does this look good to you @leandron ?

comaniac
comaniac approved these changes Mar 20, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

leandron
leandron approved these changes Mar 20, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@leandron leandron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CircleSpin

@jwfromm
Copy link
Copy Markdown
Contributor

jwfromm commented Mar 22, 2021

@merrymercy this PR is failing with this error message AttributeError: module 'tvm.auto_scheduler._ffi_api' has no attribute 'RandomModel', which almost certainly isn't caused by the changes made. Do you know what's going on?

@comaniac
Copy link
Copy Markdown
Contributor

comaniac commented Mar 23, 2021

Just a guess. Is that due to circular dependency?

@jwfromm jwfromm merged commit 1fe0abc into apache:main Mar 24, 2021
@jwfromm
Copy link
Copy Markdown
Contributor

jwfromm commented Mar 24, 2021

Thanks @CircleSpin @leandron and @comaniac. This is now merged.

@CircleSpin CircleSpin mentioned this pull request Mar 24, 2021
Merged
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request May 6, 2021
@CircleSpin
[TVMC] Python Scripting Init Files (apache#7698)
6b564e7 
* add to init files for clean tvmc python

* black reformat init.py

* adjust tests to new imports

* black test files

* tell lint ignore defined-builtin error for tvmc compile

* add colon to match lint syntax

* change import so must use tvm.driver.tvmc instead of tvm.tvmc

Co-authored-by: Jocelyn <jocelyn@pop-os.localdomain>
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request May 11, 2021
@CircleSpin @trevor-m
[TVMC] Python Scripting Init Files (apache#7698)
34f7d71 
* add to init files for clean tvmc python

* black reformat init.py

* adjust tests to new imports

* black test files

* tell lint ignore defined-builtin error for tvmc compile

* add colon to match lint syntax

* change import so must use tvm.driver.tvmc instead of tvm.tvmc

Co-authored-by: Jocelyn <jocelyn@pop-os.localdomain>
@junrushao junrushao mentioned this pull request Nov 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leandron leandron leandron approved these changes

@comaniac comaniac comaniac approved these changes

+1 more reviewer

@mdw-octoml mdw-octoml mdw-octoml approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@CircleSpin @jwfromm @comaniac @leandron @mdw-octoml