Skip to content

[5/10] Code generation for Depthwise Convolution via CMSIS-NN#9409

Merged
manupak merged 3 commits intoapache:mainfrom
asparkhi:depthwise
Nov 26, 2021
Merged

[5/10] Code generation for Depthwise Convolution via CMSIS-NN#9409
manupak merged 3 commits intoapache:mainfrom
asparkhi:depthwise

Conversation

@asparkhi
Copy link
Copy Markdown
Contributor

@asparkhi asparkhi commented Nov 1, 2021

This PR adds support for depthwise convolution via CMSIS-NN.

Here is the tracking issue: #8646

This is blocked on #9331 which is dependent on #9296.

@asparkhi
Copy link
Copy Markdown
Contributor Author

asparkhi commented Nov 1, 2021

cc: @grant-arm @Mousius @areusch for code review.

Copy link
Copy Markdown
Contributor

@manupak manupak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broadly looks good.
nits and a question.

Comment thread src/relay/backend/contrib/cmsisnn/generate_constants.cc Outdated
Comment thread tests/python/contrib/test_cmsisnn/test_conv2d.py Outdated
Copy link
Copy Markdown
Member

@Mousius Mousius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall makes sense to me, I've suggested a few things but I don't think any of them are blocking.

Comment thread src/relay/backend/contrib/cmsisnn/generate_constants.cc Outdated
Comment thread src/relay/backend/contrib/cmsisnn/relay_to_tir.cc
Comment thread src/relay/backend/contrib/cmsisnn/tir_to_runtime.cc
Comment thread tests/python/contrib/test_cmsisnn/test_conv2d.py Outdated
Ashutosh Parkhi added 3 commits November 24, 2021 17:18
Change-Id: I0a2279965a0b505f809ffcf8b955f64db8f4aff0
Change-Id: Icd9ae4d456a75761f476f8ae73bff64d48e59dd5
Change-Id: Iac6acf1c310b20b9e99bf0b9c0310423c93de9be
Copy link
Copy Markdown
Contributor

@manupak manupak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@Mousius Mousius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Post fixing CI please 😸

@manupak manupak merged commit 52edc9a into apache:main Nov 26, 2021
@manupak
Copy link
Copy Markdown
Contributor

manupak commented Nov 26, 2021

Thanks! @ashutosh-arm @Mousius

dchauhan-arm pushed a commit to dchauhan-arm/tvm that referenced this pull request Nov 29, 2021
…#9409)

This PR adds support for depthwise convolution via CMSIS-NN.
masahi pushed a commit to masahi/tvm that referenced this pull request Dec 1, 2021
…#9409)

This PR adds support for depthwise convolution via CMSIS-NN.
mehrdadh pushed a commit to mehrdadh/tvm that referenced this pull request Dec 1, 2021
…#9409)

This PR adds support for depthwise convolution via CMSIS-NN.
mehrdadh pushed a commit to mehrdadh/tvm that referenced this pull request Dec 1, 2021
…#9409)

This PR adds support for depthwise convolution via CMSIS-NN.
@asparkhi asparkhi deleted the depthwise branch December 7, 2021 10:06
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 7, 2022
…#9409)

This PR adds support for depthwise convolution via CMSIS-NN.
yangulei pushed a commit to yangulei/tvm that referenced this pull request Jan 11, 2022
…#9409)

This PR adds support for depthwise convolution via CMSIS-NN.
yangulei pushed a commit to yangulei/tvm that referenced this pull request Jan 12, 2022
…#9409)

This PR adds support for depthwise convolution via CMSIS-NN.
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
…#9409)

This PR adds support for depthwise convolution via CMSIS-NN.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants