Prevent NullPointerException if "gatewayServer" does not exist#1009
Closed
OutOfBedlam wants to merge 3 commits into
Closed
Prevent NullPointerException if "gatewayServer" does not exist#1009OutOfBedlam wants to merge 3 commits into
OutOfBedlam wants to merge 3 commits into
Conversation
Member
|
@OutOfBedlam thank you for catching this and contributing the improvement! Before merging, could you please check that your code follows project code style guide esp regardin optional braces in Java? CI failure seems un-related |
Member
|
Thank you for the prompt responce! CI passes now, proposed changes solve the issue and code looks great to me. Merging if there is no further discussion. |
Closed
AhyoungRyu
pushed a commit
to AhyoungRyu/zeppelin
that referenced
this pull request
Jun 15, 2016
### What is this PR for? Avoiding and preventing undesired NullPointerException during re-loading python interpreter Since py4j is optional when PythonInterpreter starts, it should be optional too while it close. ### What type of PR is it? [Improvement] ### What is the Jira issue? * N/A ### How should this be tested? Reload PythongInterpreter on Zeppelin web "Interpreter" menu and check the log message if it complains NullPointerException ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Kwon, Yeong-Eon <happylogin@gmail.com> Author: Y.E. Kwon <OutOfBedlam@users.noreply.github.com> Closes apache#1009 from OutOfBedlam/python and squashes the following commits: 5ed2413 [Y.E. Kwon] Fix code style ccbf7ef [Kwon, Yeong-Eon] Prevent NullPointerException if "gatewayServer" does not exist
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Avoiding and preventing undesired NullPointerException during re-loading python interpreter
Since py4j is optional when PythonInterpreter starts, it should be optional too while it close.
What type of PR is it?
[Improvement]
What is the Jira issue?
How should this be tested?
Reload PythongInterpreter on Zeppelin web "Interpreter" menu and check the log message if it complains NullPointerException
Screenshots (if appropriate)
Questions: