Skip to content

Python interpreter and doc cleanup#1021

Closed
bzz wants to merge 6 commits into
apache:masterfrom
bzz:improve/python
Closed

Python interpreter and doc cleanup#1021
bzz wants to merge 6 commits into
apache:masterfrom
bzz:improve/python

Conversation

@bzz
Copy link
Copy Markdown
Member

@bzz bzz commented Jun 16, 2016

What is this PR for?

This is first step improving current Python interpreter implementation.
It has just a cleanup, style and docs improvements.

What type of PR is it?

Improvement

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@bzz
Copy link
Copy Markdown
Member Author

bzz commented Jun 16, 2016

CI failure is not related and is taken care of under #1015

Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 34.3 sec - in org.apache.zeppelin.integration.SparkParagraphIT

Results :

Tests in error: 
  ParagraphActionsIT.testRemoveButton:153 » NoSuchElement Unable to locate eleme...
  ParagraphActionsIT.testCreateNewButton:86 » NoSuchElement Unable to locate ele...

Tests run: 14, Failures: 0, Errors: 2, Skipped: 0

Ready to be merged to master now.

@felixcheung
Copy link
Copy Markdown
Member

LGTM

@AhyoungRyu
Copy link
Copy Markdown
Contributor

LGTM 👍

@astroshim
Copy link
Copy Markdown
Contributor

LGTM

1 similar comment
@prabhjyotsingh
Copy link
Copy Markdown
Contributor

LGTM

@bzz
Copy link
Copy Markdown
Member Author

bzz commented Jun 16, 2016

Thank you for prompt reviews!

Merging if there is no more discussion.

@asfgit asfgit closed this in c806d4a Jun 17, 2016
@bzz bzz deleted the improve/python branch June 20, 2016 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants