[ZEPPELIN-1075] Merge NoteInterpreterLoader into InterpreterFactory#1102
Closed
jongyoul wants to merge 5 commits into
Closed
[ZEPPELIN-1075] Merge NoteInterpreterLoader into InterpreterFactory#1102jongyoul wants to merge 5 commits into
jongyoul wants to merge 5 commits into
Conversation
Member
Author
|
After passing the test, I'll fix some style again. |
| return com.google.common.base.Optional.of(settings.get(0)); | ||
| } | ||
|
|
||
| public com.google.common.base.Optional<InterpreterSetting> getDefaultInterpreterSetting(String noteId) { |
Contributor
There was a problem hiding this comment.
have import com.google.common.base.Optional; instead ?
Member
Author
There was a problem hiding this comment.
This is because the version of JDK installed in my mac is 1.8.x and I just add import java.util.*, then I'll fix it by each packages instead of *after passing CI.
Member
Author
|
CI becomes green. I'll fix style of some codes. |
Member
Author
|
Merging there's no more discussion |
PhilippGrulich
pushed a commit
to SWC-SENSE/zeppelin
that referenced
this pull request
Aug 8, 2016
### What is this PR for? Removing redundant codes between `NoteInterpreterLoader` and `InterpreterFactory`, reducing the cost to add new features, and making refactoring on `InterpreterFactory` easy ### What type of PR is it? [Refactoring] ### Todos * [x] - Remove `NoteInterpreterLoader` and move the functionality into `InterpreterFactory` ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-1075 ### How should this be tested? Must pass all tests ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jongyoul Lee <jongyoul@gmail.com> Closes apache#1102 from jongyoul/ZEPPELIN-1075 and squashes the following commits: d9816f1 [Jongyoul Lee] Fixed related codes a2d8104 [Jongyoul Lee] Fixed some style and removed unused codes 28bf520 [Jongyoul Lee] Fixed style 600de98 [Jongyoul Lee] Removed NoteInterpreterLoader Fixed some tests 536059b [Jongyoul Lee] Duplicated all method in NoteInterpreterLoader to InterpreterFactory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Removing redundant codes between
NoteInterpreterLoaderandInterpreterFactory, reducing the cost to add new features, and making refactoring onInterpreterFactoryeasyWhat type of PR is it?
[Refactoring]
Todos
NoteInterpreterLoaderand move the functionality intoInterpreterFactoryWhat is the Jira issue?
How should this be tested?
Must pass all tests
Screenshots (if appropriate)
Questions: