[ZEPPELIN-1099] Build and run Spark without spark-dependencies#1115
Closed
jongyoul wants to merge 1 commit into
Closed
[ZEPPELIN-1099] Build and run Spark without spark-dependencies#1115jongyoul wants to merge 1 commit into
jongyoul wants to merge 1 commit into
Conversation
Member
Author
|
Ready to review! |
Added spark-{reple,hive} in spark/pom.xml
Changed exception to throwable because of Error
Member
Author
|
Rebased it |
Member
|
looks good, I'm not exactly follow though - does one switch from building with spark-dependencies to without, with a build profile commandline, or this is permanently removing spark-dependencies from build? |
Member
Author
|
@felixcheung I think it has great benefit to include spark-dependencies by default especially for newbie. Thus I think it's enough to make building Zeppelin without spark-dependencies. |
Member
Author
|
Merging there's no more discussion. |
PhilippGrulich
pushed a commit
to SWC-SENSE/zeppelin
that referenced
this pull request
Aug 8, 2016
### What is this PR for? When users use SPARK_HOME, they won't want to include spark-dependencies. This PR makes it possible and results reducing whole size of package. ### What type of PR is it? [Feature] ### Todos * [x] - Remove dependencies of spark-dependencies ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-1099 ### How should this be tested? * Run `mvn clean package -DskipTests -pl '!spark-dependencies'` * Set SPARK_HOME in zeppelin-env.sh * Start Zeppelin * Run `sc.version` in a paragraph and check the version * Stop Zeppelin * Set SPARK_HOME in a different version * Start, check and stop I've tested it with 1.6.1 and 1.5.2. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jongyoul Lee <jongyoul@gmail.com> Closes apache#1115 from jongyoul/ZEPPELIN-1099 and squashes the following commits: 192129f [Jongyoul Lee] Removed spark-dependencies from spark Added spark-{reple,hive} in spark/pom.xml Changed exception to throwable because of Error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
When users use SPARK_HOME, they won't want to include spark-dependencies. This PR makes it possible and results reducing whole size of package.
What type of PR is it?
[Feature]
Todos
What is the Jira issue?
How should this be tested?
mvn clean package -DskipTests -pl '!spark-dependencies'sc.versionin a paragraph and check the versionI've tested it with 1.6.1 and 1.5.2.
Screenshots (if appropriate)
Questions: