Skip to content

[ZEPPELIN-1255] Add cast to string in z.show() for Pandas DataFrame #1249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bustios wants to merge 2 commits into from
Closed

[ZEPPELIN-1255] Add cast to string in z.show() for Pandas DataFrame #1249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a8c0a9
[ZEPPELIN-1255] Add cast to string in z.show() for Pandas DataFrame
bustios Jul 30, 2016
82c1412
Add test case for z.show() Pandas DataFrame
bustios Aug 1, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions python/src/main/resources/bootstrap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,19 +140,19 @@ def show_dataframe(self, df, **kwargs):
"""
limit = len(df) > self.max_result
header_buf = io.StringIO("")
header_buf.write(df.columns[0])
header_buf.write(str(df.columns[0]))
for col in df.columns[1:]:
header_buf.write("\t")
header_buf.write(col)
header_buf.write(str(col))
header_buf.write("\n")

body_buf = io.StringIO("")
rows = df.head(self.max_result).values if limit else df.values
for row in rows:
body_buf.write(row[0])
body_buf.write(str(row[0]))
for cell in row[1:]:
body_buf.write("\t")
body_buf.write(cell)
body_buf.write(str(cell))
body_buf.write("\n")
body_buf.seek(0); header_buf.seek(0)
#TODO(bzz): fix it, so it shows red notice, as in Spark
Expand Down
20 changes: 20 additions & 0 deletions python/src/test/java/org/apache/zeppelin/python/PythonInterpreterPandasSqlTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,4 +153,24 @@ public void badSqlSyntaxFails() {
assertTrue(ret.message().length() > 0);
}

@Test
public void showDataFrame() {
InterpreterResult ret;
ret = python.interpret("import pandas as pd", context);
ret = python.interpret("import numpy as np", context);

// given a Pandas DataFrame with non-text data
ret = python.interpret("d1 = {1 : [np.nan, 1, 2, 3], 'two' : [3., 4., 5., 6.7]}", context);
ret = python.interpret("df1 = pd.DataFrame(d1)", context);
assertEquals(ret.message(), InterpreterResult.Code.SUCCESS, ret.code());

// when
ret = python.interpret("z.show(df1)", context);

// then
assertEquals(ret.message(), InterpreterResult.Code.SUCCESS, ret.code());
assertEquals(ret.message(), Type.TABLE, ret.type());
assertTrue(ret.message().indexOf("nan") > 0);
assertTrue(ret.message().indexOf("6.7") > 0);
}
}