[ZEPPELIN-1261] Bug fix in z.show() for matplotlib graphs#1267
Closed
bustios wants to merge 2 commits into
Closed
Conversation
Member
|
Looks great to me, thank you @bustios ! Just FYI - in case of CI failure, If contributor posts failure logs from TravisCI, that helps to improve project stability a lot as it makes people fix flaky tests, infrastructural problems, etc. Current CI failure is due to flaky same as #1249 #1051 #1160 #1043 #943 and #835. Logged under ZEPPELIN-1271 Merging to master if there is no further discussion |
Contributor
Author
|
I see. Thanks for your help and information @bzz. I'll keep it in mind for subsequent PRs |
Member
|
Sounds great! Apparently CI failure has been addressed in #1259 as well |
PhilippGrulich
pushed a commit
to SWC-SENSE/zeppelin
that referenced
this pull request
Aug 8, 2016
### What is this PR for? Bug fix in z.show() for matplotlib graphs and code refactoring ### What type of PR is it? Bug Fix ### What is the Jira issue? [ZEPPELIN-1261](https://issues.apache.org/jira/browse/ZEPPELIN-1261) ### How should this be tested? ``` %python import matplotlib.pyplot as plt x = [1,2,3,4,5] y = [6,7,8,9,0] plt.plot(x, y, marker="o") z.show(plt, height="20em") plt.close() ``` ``` %python import matplotlib.pyplot as plt x = [1,2,3,4,5] y = [6,7,8,9,0] plt.plot(x, y, marker="o") z.show(plt, height="300px") plt.close() ``` ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Paul Bustios <pbustios@gmail.com> Closes apache#1267 from bustios/ZEPPELIN-1261 and squashes the following commits: 82c631a [Paul Bustios] Add 100% as a default value for width and height z.show() parameters 3e0ef22 [Paul Bustios] Bug fix in show_matplotlib
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Bug fix in z.show() for matplotlib graphs and code refactoring
What type of PR is it?
Bug Fix
What is the Jira issue?
ZEPPELIN-1261
How should this be tested?
Screenshots (if appropriate)
Questions: