Small refactoring of Python interpreter#1275
Closed
bzz wants to merge 2 commits into
Closed
Conversation
Member
Author
|
Ready to be merged |
Member
|
LGTM |
Member
Author
|
Thank you @minahlee for prompt review! CI fails on spark 1.6 profile, same as master, and #1263 handled under ZEPPELIN-1286 Merging to master if there is no further discussion. |
PhilippGrulich
pushed a commit
to SWC-SENSE/zeppelin
that referenced
this pull request
Aug 8, 2016
### What is this PR for? Small refactoring of Python interpreter, that is what it is. ### What type of PR is it? Refactoring ### Todos * [x] refactor `help()` * [x] impl `maxResult` fetch from JVM ### How should this be tested? `cd python && mvn -Dpython.test.exclude='' test ` pass (given that `pip install pandasql` and `pip install py4j`) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Alexander Bezzubov <bzz@apache.org> Closes apache#1275 from bzz/python/refactoring and squashes the following commits: 15a35c8 [Alexander Bezzubov] Make .help() method a single string literal e800fd7 [Alexander Bezzubov] Make Python fetch maxResults from JVM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Small refactoring of Python interpreter, that is what it is.
What type of PR is it?
Refactoring
Todos
help()maxResultfetch from JVMHow should this be tested?
cd python && mvn -Dpython.test.exclude='' testpass (given thatpip install pandasqlandpip install py4j)Questions: