Skip to content

ZEPPELIN-148 Notebook scope AngularObject for Angular display system#143

Closed
Leemoonsoo wants to merge 17 commits into
apache:masterfrom
Leemoonsoo:localscope
Closed

ZEPPELIN-148 Notebook scope AngularObject for Angular display system#143
Leemoonsoo wants to merge 17 commits into
apache:masterfrom
Leemoonsoo:localscope

Conversation

@Leemoonsoo
Copy link
Copy Markdown
Member

@Leemoonsoo Leemoonsoo changed the title [WIP] ZEPPELIN-148 Notebook scope AngularObject for Angular display system ZEPPELIN-148 Notebook scope AngularObject for Angular display system Jul 4, 2015
@Leemoonsoo
Copy link
Copy Markdown
Member Author

This PR introduces a two different scope for a angularObject. One localScope(notebook scope) and the other globalScope(interpreter scope).
Also includes end-to-end test that covers front-end interaction.
I think this pr will really help make this feature from experimental to beta.

Ready to merge.

@Leemoonsoo
Copy link
Copy Markdown
Member Author

merging if there're no more discussions.

Leemoonsoo added a commit that referenced this pull request Jul 12, 2015
Described https://issues.apache.org/jira/browse/ZEPPELIN-148

Author: Lee moon soo <moon@apache.org>

Closes #143 from Leemoonsoo/localscope and squashes the following commits:

51340d2 [Lee moon soo] Increase paragraph run timeout
e00a9af [Lee moon soo] Fix test
80ff3d4 [Lee moon soo] Fix style
ead4f70 [Lee moon soo] Front end interaction test with angularBind, angularUnbind, angularWatch
c7c63d1 [Lee moon soo] make sure test is executed
d74820f [Lee moon soo] Enabling selenium test
b817bd9 [Lee moon soo] Cleanup the message
bcb60f8 [Lee moon soo] Clear object correctly
12bb15a [Lee moon soo] Fix style
699defd [Lee moon soo] Handle ANGULAR_OBJECT_REMOVE event in front-end.
1c695c0 [Lee moon soo] Send angularObject add/remove event from ZeppelinServer to remote process
195a8c9 [Lee moon soo] Add Unbind api for global scope object
378df68 [Lee moon soo] Remove angularObject when notebook removal
3548cb5 [Lee moon soo] Fix test
093870c [Lee moon soo] save / load angular object
25cf5da [Lee moon soo] Take all objects
bb757e3 [Lee moon soo] Introduce scope (global/local) for angular object
@stumped2
Copy link
Copy Markdown
Member

@stumped2 stumped2 closed this Jul 13, 2015
Leemoonsoo added a commit to Leemoonsoo/zeppelin that referenced this pull request Sep 17, 2015
Described https://issues.apache.org/jira/browse/ZEPPELIN-148

Author: Lee moon soo <moon@apache.org>

Closes apache#143 from Leemoonsoo/localscope and squashes the following commits:

51340d2 [Lee moon soo] Increase paragraph run timeout
e00a9af [Lee moon soo] Fix test
80ff3d4 [Lee moon soo] Fix style
ead4f70 [Lee moon soo] Front end interaction test with angularBind, angularUnbind, angularWatch
c7c63d1 [Lee moon soo] make sure test is executed
d74820f [Lee moon soo] Enabling selenium test
b817bd9 [Lee moon soo] Cleanup the message
bcb60f8 [Lee moon soo] Clear object correctly
12bb15a [Lee moon soo] Fix style
699defd [Lee moon soo] Handle ANGULAR_OBJECT_REMOVE event in front-end.
1c695c0 [Lee moon soo] Send angularObject add/remove event from ZeppelinServer to remote process
195a8c9 [Lee moon soo] Add Unbind api for global scope object
378df68 [Lee moon soo] Remove angularObject when notebook removal
3548cb5 [Lee moon soo] Fix test
093870c [Lee moon soo] save / load angular object
25cf5da [Lee moon soo] Take all objects
bb757e3 [Lee moon soo] Introduce scope (global/local) for angular object

(cherry picked from commit 201ce8d)
Signed-off-by: Lee moon soo <moon@apache.org>
ajgoade pushed a commit to ajgoade/zeppelin that referenced this pull request Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants