[DOCS] Separate "interpreter exec hooks (experimental)" from interpreter overview page#1768
Closed
AhyoungRyu wants to merge 1 commit into
Closed
[DOCS] Separate "interpreter exec hooks (experimental)" from interpreter overview page#1768AhyoungRyu wants to merge 1 commit into
AhyoungRyu wants to merge 1 commit into
Conversation
Contributor
Author
|
@agoodm Since you added this section, it'll be appreciated if you can review this one :) |
Member
|
Thanks for the update! I probably should have done this when I made the original PR. Anyways, LGTM. |
Contributor
Author
|
@agoodm No worries. Thanks! |
Contributor
|
Tested and LGTM! |
Contributor
Author
|
@agoodm @soralee Thanks for your review! CI failed only in Selenium test like below and it's not related with this docs change. Merge into master if there are no further discussions :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
After #1470 merged, "(Experimental) Interpreter Execution Hooks" is added under https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/manual/interpreters.html page. But i think we need to keep this page as simple as possible since it's explaining the basic concept of Zeppelin interpreters. So I separated "(Experimental) Interpreter Execution Hooks" section from
interpreters.mdand created new pageinterpreterexechooks.md.And also fixed some markdown rendering issues.
What type of PR is it?
Documentation
What is the Jira issue?
N/A
How should this be tested?
Please see below screenshots :)
Screenshots (if appropriate)
Questions: