[ZEPPELIN-2154] Support zeppelin.server.port in dev mode (branch-0.7)#2124
Closed
soralee wants to merge 1 commit into
Closed
[ZEPPELIN-2154] Support zeppelin.server.port in dev mode (branch-0.7)#2124soralee wants to merge 1 commit into
soralee wants to merge 1 commit into
Conversation
Member
Contributor
Author
|
Sure! Thanks @Leemoonsoo for inform it |
soralee
force-pushed
the
ZEPPELIN-2154_0.7_server_port
branch
2 times, most recently
from
b3eff9d to
67c9e7b
Compare
soralee
force-pushed
the
ZEPPELIN-2154_0.7_server_port
branch
from
67c9e7b to
8633842
Compare
Contributor
|
LGTM |
asfgit
pushed a commit
that referenced
this pull request
Apr 8, 2017
### What is this PR for? If user change `zeppelin.server.port` variable in zeppelin-site.xml, zeppelin doesn't work in web development on `branch-0.7` #2097 PR which is same issue on master branch was already merged to master branch. ### What type of PR is it? [Bug Fix | Improvement | Documentation (README.md)] ### What is the Jira issue? * [ZEPPELIN-2154](https://issues.apache.org/jira/browse/ZEPPELIN-2154) ### How should this be tested? 1. Change `zeppelin.server.port` from 8080 to 8888 (or another port) in `zeppelin-site.xml` 2. Run zeppelin (`bin/zeppelin-daemon.sh start`) 3. Run web development mode under zeppelin-web folder such like `SERVER_PORT=8888 yarn run dev` 4. Connect localhost:9000 ### Screenshots (if appropriate) **[Before]**  **[After]**   ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does thi`sneeds documentation? Yes, `README.md` Author: soralee <sora0728@zepl.com> Closes #2124 from soralee/ZEPPELIN-2154_0.7_server_port and squashes the following commits: 8633842 [soralee] [ZEPPELIN-2154] Support zeppelin.server.port in dev mode (branch-0.7)
Contributor
|
@soralee I just merged this PR into branch-0.7 but it's not closed automatically. Could you close it in your side? |
Contributor
Author
|
I did, Thanks @AhyoungRyu |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
If user change
zeppelin.server.portvariable in zeppelin-site.xml, zeppelin doesn't work in web development onbranch-0.7#2097 PR which is same issue on master branch was already merged to master branch.
What type of PR is it?
[Bug Fix | Improvement | Documentation (README.md)]
What is the Jira issue?
How should this be tested?
zeppelin.server.portfrom 8080 to 8888 (or another port) inzeppelin-site.xmlbin/zeppelin-daemon.sh start)SERVER_PORT=8888 yarn run devScreenshots (if appropriate)
[Before]
[After]
Questions:
sneeds documentation? Yes,README.md`