Skip to content

[ZEPPELIN-2512] Prevent slow note, interpreter search. (master, branch-0.7) #2324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1ambda wants to merge 2 commits into from
Closed

[ZEPPELIN-2512] Prevent slow note, interpreter search. (master, branch-0.7) #2324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b792ee5
feat: Add debounce for note name filter
1ambda May 8, 2017
20292fb
feat: Add debounce for interpreter search input
1ambda May 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion zeppelin-web/src/app/interpreter/interpreter.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,10 @@ <h3 class="new_h3">
<div class="row">
<div class="col-md-4">
<div class="input-group" style="margin-top: 10px">
<input type="text" ng-model="searchInterpreter" class="form-control ng-pristine ng-untouched ng-valid ng-empty" placeholder="Search interpreters"/>
<input type="text" ng-model="searchInterpreter"
class="form-control ng-pristine ng-untouched ng-valid ng-empty"
ng-model-options="{ updateOn: 'default blur', debounce: { 'default': 300, 'blur': 0 } }"
placeholder="Search interpreters"/>
<span class="input-group-btn">
<button type="submit" class="btn btn-default" ng-disabled="!navbar.connected">
<i class="glyphicon glyphicon-search"></i>
Expand Down
8 changes: 6 additions & 2 deletions zeppelin-web/src/components/filterNoteNames/filter-note-names.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,9 @@
See the License for the specific language governing permissions and
limitations under the License.
-->
<input type="text" class="note-name-query form-control" ng-click="$event.stopPropagation()"
placeholder="&#xf002 Filter" ng-model="$parent.query.q" />
<input type="text"
class="note-name-query form-control"
ng-click="$event.stopPropagation()"
placeholder="&#xf002 Filter"
ng-model="$parent.query.q"
ng-model-options="{ updateOn: 'default blur', debounce: { 'default': 300, 'blur': 0 } }" />