Skip to content

[ZEPPELIN-2520] DON'T set bottom margin for markdown table#2327

Closed
1ambda wants to merge 3 commits into
apache:masterfrom
1ambda:ZEPPELIN-2520/bottom-margin-for-md-table
Closed

[ZEPPELIN-2520] DON'T set bottom margin for markdown table#2327
1ambda wants to merge 3 commits into
apache:masterfrom
1ambda:ZEPPELIN-2520/bottom-margin-for-md-table

Conversation

@1ambda
Copy link
Copy Markdown
Member

@1ambda 1ambda commented May 9, 2017

What is this PR for?

DON'T set bottom margin for the markdown table.

Implementation Details

that's because .paragraph table overwrites .markdown-body table

image

What type of PR is it?

[Bug Fix]

Todos

  • - Bump version up from 2.4.0 to 2.6.0
  • - Update bin_license/LICENSE
  • - Import it using commonjs
  • - Fix paragraph.css

What is the Jira issue?

ZEPPELIN-2520

How should this be tested?

  1. Build: mvn clean package -DskipTests;
  2. Execute a paragraph using this text.
Colons can be used to align columns.

| Tables        | Are           | Cool  |
| ------------- |:-------------:| -----:|
| col 3 is      | right-aligned | $1600 |
| col 2 is      | centered      |   $12 |
| zebra stripes | are neat      |    $1 |

There must be at least 3 dashes separating each header cell.
The outer pipes (|) are optional, and you don't need to make the 
raw Markdown line up prettily. You can also use inline Markdown.

Markdown | Less | Pretty
--- | --- | ---
*Still* | `renders` | **nicely**
1 | 2 | 3

Screenshots (if appropriate)

Before

image

After

image

Questions:

  • Does the licenses files need update?
  • Is there breaking changes for older versions?
  • Does this needs documentation?

@1ambda
Copy link
Copy Markdown
Member Author

1ambda commented May 10, 2017

@soralee
Copy link
Copy Markdown
Contributor

soralee commented May 10, 2017

Nicely fixed bug and improved things!
Let me test and give you feedback!

@soralee
Copy link
Copy Markdown
Contributor

soralee commented May 12, 2017

Tested and it's work well.
My result are exactly same the above after and before screenshots.
LGTM.

@Leemoonsoo
Copy link
Copy Markdown
Member

LGTM and merge to master if no further comments.

@1ambda 1ambda force-pushed the ZEPPELIN-2520/bottom-margin-for-md-table branch from 41590a9 to 2c54b66 Compare May 13, 2017 12:06
@1ambda 1ambda closed this May 13, 2017
@1ambda 1ambda reopened this May 13, 2017
@asfgit asfgit closed this in ed2422a May 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants