ZEPPELIN-3106. User impersonation in SPARK is not working#2705
Closed
zjffdu wants to merge 2 commits into
Closed
Conversation
Contributor
Author
|
@prabhjyotsingh Could you help review it ? Thanks |
Contributor
|
Will try this for both spark and shell interpreter, and post my finding later today. |
| fi | ||
|
|
||
| if [[ -n "${SPARK_SUBMIT}" ]]; then | ||
| if [[ -n "$ZEPPELIN_IMPERSONATE_USER" ]] && [[ "$ZEPPELIN_IMPERSONATE_SPARK_PROXY_USER" != "false" ]]; then |
Contributor
There was a problem hiding this comment.
By removing this ZEPPELIN_IMPERSONATE_SPARK_PROXY_USER you disable the feature that was introduced with #1840 (# export ZEPPELIN_IMPERSONATE_SPARK_PROXY_USER #Optional, by default is true; can be set to false if you don't want to use --proxy-user option with Spark interpreter when impersonation enabled), is that intended? If so, we will need to update the doc.
zjffdu
force-pushed
the
ZEPPELIN-3106
branch
from
4c52bc4 to
957701e
Compare
felixcheung
reviewed
Dec 20, 2017
| @@ -196,10 +199,10 @@ private boolean isYarnMode() { | |||
| private String toShellFormat(String value) { | |||
| if (value.contains("\'") && value.contains("\"")) { | |||
prabhjyotsingh
approved these changes
Dec 20, 2017
| if [[ -n "${SPARK_SUBMIT}" ]]; then | ||
| if [[ -n "$ZEPPELIN_IMPERSONATE_USER" ]] && [[ "$ZEPPELIN_IMPERSONATE_SPARK_PROXY_USER" != "false" ]]; then | ||
| INTERPRETER_RUN_COMMAND+=' '` echo ${SPARK_SUBMIT} --class ${ZEPPELIN_SERVER} --driver-class-path \"${ZEPPELIN_INTP_CLASSPATH_OVERRIDES}:${ZEPPELIN_INTP_CLASSPATH}\" --driver-java-options \"${JAVA_INTP_OPTS}\" ${SPARK_SUBMIT_OPTIONS} ${ZEPPELIN_SPARK_CONF} --proxy-user ${ZEPPELIN_IMPERSONATE_USER} ${SPARK_APP_JAR} ${CALLBACK_HOST} ${PORT} ${INTP_PORT}` | ||
| INTERPRETER_RUN_COMMAND+=' '` echo ${SPARK_SUBMIT} --class ${ZEPPELIN_SERVER} --driver-class-path \"${ZEPPELIN_INTP_CLASSPATH_OVERRIDES}:${ZEPPELIN_INTP_CLASSPATH}\" --driver-java-options \"${JAVA_INTP_OPTS}\" ${SPARK_SUBMIT_OPTIONS} ${ZEPPELIN_SPARK_CONF} ${SPARK_APP_JAR} ${CALLBACK_HOST} ${PORT} ${INTP_PORT}` |
Contributor
There was a problem hiding this comment.
Both if and else are same!
zjffdu
force-pushed
the
ZEPPELIN-3106
branch
from
112e9d3 to
4da6e1d
Compare
zjffdu
force-pushed
the
ZEPPELIN-3106
branch
from
4da6e1d to
2a6cb14
Compare
Contributor
Author
|
Thanks @prabhjyotsingh comments has been addressed. And CI passed |
Contributor
|
Rest, looks good. |
Contributor
Author
|
Thanks, Merge if no more comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR is for trying to fix the impersonation of spark interpreter in master branch. For spark impersonation, we don't need to ssh, just adding
--proxy-useris enough.What type of PR is it?
[Bug Fix]
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: