Skip to content

added autocompletion#382

Closed
xhudik wants to merge 1 commit into
apache:masterfrom
xhudik:patch-3
Closed

added autocompletion#382
xhudik wants to merge 1 commit into
apache:masterfrom
xhudik:patch-3

Conversation

@xhudik
Copy link
Copy Markdown
Contributor

@xhudik xhudik commented Oct 31, 2015

auto-completion shortcut was missing

@xhudik
added autocompletion
ed3ee01 
auto-completion shortcut was missing
@Leemoonsoo
Copy link
Copy Markdown
Member

Leemoonsoo commented Nov 2, 2015

LGTM

@Leemoonsoo
Copy link
Copy Markdown
Member

Leemoonsoo commented Nov 2, 2015

merge if there're no more discussions

@xhudik
Copy link
Copy Markdown
Contributor Author

xhudik commented Nov 2, 2015

one question:
is there any other shortcut? I'm wondering whether there is nothing for cell manipulation (inserting, moving up and down,...) - such procedures are quite common so shortcuts would be handy ...

@Leemoonsoo
Copy link
Copy Markdown
Member

Leemoonsoo commented Nov 2, 2015

No shortcuts yet. There are one really old attempt for shortcuts. Definitely keyboard shortcuts will help a lot.

@xhudik
Copy link
Copy Markdown
Contributor Author

xhudik commented Nov 2, 2015

right, so it requires additional work :(. In this case, this pull request should be ok for now

@felixcheung
Copy link
Copy Markdown
Member

felixcheung commented Nov 2, 2015

LGTM

@asfgit asfgit closed this in 600f728 Nov 3, 2015
prabhjyotsingh pushed a commit to prabhjyotsingh/zeppelin that referenced this pull request Nov 3, 2015
@xhudik @prabhjyotsingh
added autocompletion
3d90231 
auto-completion shortcut was missing

Author: Tomas <xhudik@gmail.com>

Closes apache#382 from xhudik/patch-3 and squashes the following commits:

ed3ee01 [Tomas] added autocompletion
prabhjyotsingh pushed a commit to prabhjyotsingh/zeppelin that referenced this pull request Nov 3, 2015
@xhudik @prabhjyotsingh
added autocompletion
18ed8c4 
auto-completion shortcut was missing

Author: Tomas <xhudik@gmail.com>

Closes apache#382 from xhudik/patch-3 and squashes the following commits:

ed3ee01 [Tomas] added autocompletion
@felixcheung
Copy link
Copy Markdown
Member

felixcheung commented Nov 3, 2015

Do we have a JIRA for the additional work? If not, @xhudik could you create one?

@xhudik
Copy link
Copy Markdown
Contributor Author

xhudik commented Nov 4, 2015

@felixcheung - i don't have too much time, but I'll try to find some and create it within 2-3 days

@xhudik
Copy link
Copy Markdown
Contributor Author

xhudik commented Nov 4, 2015

@felixcheung - I created one general issue/feature improvement request: https://issues.apache.org/jira/browse/ZEPPELIN-391 - let's discuss there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xhudik @Leemoonsoo @felixcheung