[WIP] Fix notebook clone bug#458
Closed
minahlee wants to merge 1 commit into
Closed
Conversation
Member
|
Looks great, but how complicated is it to reproduce this bug? Also a bit of explanation in comments in case of empty catch block (i.e why is it ok to ignore it here) is of a good style |
Member
There was a problem hiding this comment.
does result == null cause problem to paragraph.setReturn?
Member
|
Looks like build failed due to networking issue on downloading mvn dependencies. Should not be reproducible. |
Member
Author
|
Duplicated with #933 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle exception when paragraph's
getReturnmethod returns unparseable object.