[ZEPPELIN-6421] Integrate zeppelin-react lint into root lint script#5258
Open
tbonelee wants to merge 1 commit into
Open
[ZEPPELIN-6421] Integrate zeppelin-react lint into root lint script#5258tbonelee wants to merge 1 commit into
tbonelee wants to merge 1 commit into
Conversation
zeppelin-react has its own ESLint config (with rules at error level) but was not wired into the root lint script. Mirror the existing build:react pattern with lint:react and lint:fix:react, and include them in the root composite lint scripts so Maven's npm lint execution catches ESLint violations in zeppelin-react.
Contributor
Author
|
@voidmatcha Could you take a quick look at this when you have a moment? |
voidmatcha
approved these changes
May 25, 2026
Contributor
voidmatcha
left a comment
voidmatcha
left a comment
There was a problem hiding this comment.
LGTM.
Tried it in local env: dropped a deliberate const x: any into projects/zeppelin-react/src/utils/index.ts and npm run lint:react flagged it as @typescript-eslint/no-explicit-any (exit 1); clean source returns exit 0. So the new script actually catches what Maven's npm lint was missing.
I'll handle the Playwright auth-variant flakiness in a separate PR under ZEPPELIN-6422.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
zeppelin-reacthas its own ESLint config with rules aterrorlevel (e.g.@typescript-eslint/no-explicit-any,react-hooks/exhaustive-deps), but its lint script is not wired into the rootnpm run lintofzeppelin-web-angular. As a result, Maven'snpm lintexecution (zeppelin-web-angular/pom.xml) does not catch ESLint violations inzeppelin-react.What changes are proposed?
Mirror the existing
build:reactpattern withlint:react/lint:fix:reactscripts and include them in the root compositelintandlint:fixscripts. Thepostinstallhook already installsprojects/zeppelin-react/node_modules, so no extra install step is needed.What type of PR is it?
Improvement
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-6421
How should this be tested?
Run
npm run lintinsidezeppelin-web-angular/and confirm that zeppelin-react ESLint errors are reported.Screenshots (if appropriate)
N/A
Questions: