[ZEPPELIN-792]Misspelt words and Wrong method parameters#817
Closed
zuny25 wants to merge 2 commits into
Closed
Conversation
org.sonatype.aether/aether-api/1.12 / org.sonatype.aether.repository.RemoteRepository public RemoteRepository setPolicy( boolena snapshot, RepositoryPolicy policy) org.sonatype.aether/aether-api/1.12 / org.sonatype.aether.repository.RepositoryPolicy public More ...RepositoryPolicy( boolean enabled, String updatePolicy, String checksumPolicy ) I think two paraemter have to changed its position
| RemoteRepository rr = new RemoteRepository(id, "default", url); | ||
| rr.setPolicy(true, new RepositoryPolicy( | ||
| snapshot, | ||
| rr.setPolicy(snapshot, new RepositoryPolicy( |
Member
There was a problem hiding this comment.
I believe just new RepositoryPolicy() will do the same thing
Member
|
LGTM |
Contributor
|
@zuny25 Could you rebase this one and re-trigger the CI? |
Member
|
@zuny25 thank you for contribution! |
Contributor
|
Merging if there is no more discussions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Fix misspelt words and wrong method parameter on zeppelin-interpreter
https://issues.apache.org/jira/browse/ZEPPELIN-792
What type of PR is it?
Bug Fix
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: