[ZEPPELIN-835]Don't persist authentication info into note.json

[mwkang]

What is this PR for?

Don't persist authentication info into note.json

What type of PR is it?

Bug Fix

Todos

What is the Jira issue?

• https://issues.apache.org/jira/browse/ZEPPELIN-835

How should this be tested?

unit test

Screenshots (if appropriate)

Questions:

• Does the licenses files need update? no
• Is there breaking changes for older versions? no
• Does this needs documentation? no

[Leemoonsoo]

@mwkang Thanks for the fix. It looks good. Do you mind re-trigger the CI?

[mwkang]

Of course. I close the PR and re-open to re-trigger the ci.

[mwkang]

@Leemoonsoo Part of Ci are failed. Because..

[ERROR] Failed to execute goal on project zeppelin-zrinterpreter: Could not resolve dependencies for project org.apache.zeppelin:zeppelin-zrinterpreter:jar:0.6.0-incubating-SNAPSHOT: Could not transfer artifact org.apache.spark:spark-core_2.10:jar:1.4.1 from/to central (http://repo.maven.apache.org/maven2): GET request of: org/apache/spark/spark-core_2.10/1.4.1/spark-core_2.10-1.4.1.jar from central failed: Connection reset -> [Help 1]

Is it Okay? I'm not sure it is not related this PR, isn't it?

[Leemoonsoo]

The first CI profile runs this test and it is passing. Other CI failure is unrelated to this change.

LGTM

[bzz]

Changes look good to me, and CI failure is unrelated.

Guys, in effort to improve build stability, would it be reasonable to have some kind of agreement that in case of such build failures - we create a JIRA issues first, tag like flaky-build, link logs of failing build and only then proceed \w contributions that stumbled up on such issues?

That would help PMC a great deal to identify common infrastructure problems and focus on fixing them.

[mwkang]

@bzz I think I don't understand 100%. So I want to more clearly what you are saying.
If I am impolite, I am so sorry.
Is the meaning I make a JIRA issue about failing CI?
and... It is more helpful to PMC, isn't it?

[bzz]

@mwkang no problem!
yes, JIRA issue for failing CI with label flaky-build (even if it does not block this PR) would help us improving the CI.

Code looks good to me and 👍 for having a test!

[mwkang]

@bzz Thanks for your comment. It is really helpful. and now I understand 100%! 😄

[mwkang]

I made 2 issue for failing CI.
ZEPPELIN-876, ZEPPELIN-877

[felixcheung]

thanks, looks like Selenium tests have been busted by a merged code change. thanks for opening ZEPPELIN-876.

[corneadoug]

@mwkang Could you rebase this PR please?

[mwkang]

While I rebase this PR, I found this issue was been resolved AuthenticationInfo in master.
So I closed PR.

[mwkang]

Related PR: #860
Related Issue: https://issues.apache.org/jira/browse/ZEPPELIN-828

[corneadoug]

@Leemoonsoo Can we close this JIRA issue then? https://issues.apache.org/jira/browse/ZEPPELIN-835

[mwkang]

Oh.. I resolved JIRA issue.
I am so sorry that I act at my discretion.

[corneadoug]

@mwkang It's fine, we can always reopen it if necessary. Just wanted @Leemoonsoo go to close it since he was the one to report it