Skip to content

[ZEPPELIN-881] Apache Ignite version updated to 1.6#916

Closed
agura wants to merge 1 commit into
apache:masterfrom
agura:ZEPPELIN-881
Closed

[ZEPPELIN-881] Apache Ignite version updated to 1.6#916
agura wants to merge 1 commit into
apache:masterfrom
agura:ZEPPELIN-881

Conversation

@agura
Copy link
Copy Markdown
Contributor

@agura agura commented May 25, 2016

What is this PR for?

Apache Ignite 1.6 contains JDBC driver improvements that affect Zeppelin Ignite interpreter user experience.

What type of PR is it?

[Improvement]

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-881

@jongyoul
Copy link
Copy Markdown
Member

Simple! Great! And I think Ignite JDBC interpreter doesn't have any special thing. How do you think it merges into JDBC interpreter?

@jongyoul
Copy link
Copy Markdown
Member

Without the issue above, this PR looks good to me.

@agura
Copy link
Copy Markdown
Contributor Author

agura commented May 26, 2016

@jongyoul Ignite JDBC interpreter has some specific options, so I need to investigate possibility of usage generic JDBC interpreter. I think the best way is to merge this PR in order to include new drivers in 0.6.0 release.

@jongyoul
Copy link
Copy Markdown
Member

@agura I'll thank you if you help merge Ignite JDBC into generic JDBC interpreter.

And about this PR, it looks good to me. Merging if there's no more discussion.

@agura
Copy link
Copy Markdown
Contributor Author

agura commented May 30, 2016

Guys, can anybody merge this PR into master branch?

@jongyoul
Copy link
Copy Markdown
Member

jongyoul commented May 30, 2016

@agura Hi, one of CI test fails. Could you please check it?

@agura
Copy link
Copy Markdown
Contributor Author

agura commented May 30, 2016

@jongyoul How to rerun tests?

@jongyoul
Copy link
Copy Markdown
Member

@agura Close and re-open this PR

@agura agura closed this May 30, 2016
@agura agura reopened this May 30, 2016
@jongyoul
Copy link
Copy Markdown
Member

@Leemoonsoo Could you please check that failure due to flaky test?

@bzz
Copy link
Copy Markdown
Member

bzz commented May 31, 2016

@jongyoul first thing to do is to check JIRA flaky-test label and see if there is an existing issue for this failure.

The CI failure is not related to the changes and I think is already tracked under https://issues.apache.org/jira/browse/ZEPPELIN-888 so I have added this failure there as well.

Looks good to me, merging if there is no further discussion

@asfgit asfgit closed this in f291b26 May 31, 2016
@agura
Copy link
Copy Markdown
Contributor Author

agura commented May 31, 2016

Thx, guys!

@jongyoul
Copy link
Copy Markdown
Member

We also appreciate your contribution!

asfgit pushed a commit that referenced this pull request Jun 8, 2016
### What is this PR for?
While Apache Ignite version in Zeppelin was bumped up by #916, but ignite build flag in [README.md](https://github.com/apache/incubator-zeppelin/blob/master/README.md#ignite-interpreter) is outdated so far. So I just changed `1.1.0-incubating` -> `1.6.0`.

### What type of PR is it?
Hot Fix

### Todos

### What is the Jira issue?

### How should this be tested?
Just see [here](https://github.com/apache/incubator-zeppelin/blob/master/README.md#ignite-interpreter).

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: AhyoungRyu <fbdkdud93@hanmail.net>

Closes #970 from AhyoungRyu/update/README.md and squashes the following commits:

20d0155 [AhyoungRyu] Update README.md for fixing ignite flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants