Skip to content

[ZEPPELIN-952] Refine website style#962

Closed
minahlee wants to merge 10 commits into
apache:masterfrom
minahlee:ZEPPELIN-952
Closed

[ZEPPELIN-952] Refine website style#962
minahlee wants to merge 10 commits into
apache:masterfrom
minahlee:ZEPPELIN-952

Conversation

@minahlee
Copy link
Copy Markdown
Member

@minahlee minahlee commented Jun 5, 2016

What is this PR for?

  • update document style (font, line-spacing)
  • apply same formats for documents
  • fix broke document styles

What type of PR is it?

Documentation

What is the Jira issue?

ZEPPELIN-952

Screenshots (if appropriate)

Before
screen shot 2016-06-04 at 9 51 38 pm

After
screen shot 2016-06-04 at 9 15 08 pm

Before
screen shot 2016-06-04 at 10 08 53 pm

After
screen shot 2016-06-04 at 10 08 18 pm

Before
screen shot 2016-06-04 at 10 10 47 pm

After
screen shot 2016-06-04 at 10 11 22 pm

Before
screen shot 2016-06-04 at 10 12 36 pm

After
screen shot 2016-06-04 at 10 12 55 pm

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@AhyoungRyu
Copy link
Copy Markdown
Contributor

@minahlee Nice work! Definitely it looks much better than before 👍

@bzz
Copy link
Copy Markdown
Member

bzz commented Jun 6, 2016

👍 looks great to me!

@Leemoonsoo
Copy link
Copy Markdown
Member

Looks good to me!

@lresende
Copy link
Copy Markdown
Member

lresende commented Jun 6, 2016

Nice, LGTM

asfgit pushed a commit that referenced this pull request Jun 6, 2016
…er.md

### What is this PR for?
Currently some code blocks in [docs/development/writingzeppelininterpreter.html](https://zeppelin.apache.org/docs/0.6.0-SNAPSHOT/development/writingzeppelininterpreter.html) & [docs/storage/storage.html#S3](https://zeppelin.apache.org/docs/0.6.0-SNAPSHOT/storage/storage.html) are broken.

But it seems the broken code block  in `docs/storage/storage.html` is already handled in #962. So I just updated in `docs/development/writingzeppelininterpreter.html`

### What type of PR is it?
Hot Fix

### Todos

### What is the Jira issue?
[ZEPPELIN-959](https://issues.apache.org/jira/browse/ZEPPELIN-959)

### How should this be tested?
See the attached images :)

### Screenshots (if appropriate)
- Before
![docs-before2](https://cloud.githubusercontent.com/assets/10060731/15812570/6d70ba16-2b6b-11e6-8486-86052e8ceeed.gif)

- After
<img width="1077" alt="screen shot 2016-06-05 at 7 38 50 pm" src="https://cloud.githubusercontent.com/assets/10060731/15812563/4b36e696-2b6b-11e6-8f14-f4572331eec6.png">

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: AhyoungRyu <fbdkdud93@hanmail.net>

Closes #969 from AhyoungRyu/ZEPPELIN-959 and squashes the following commits:

8f8cc70 [AhyoungRyu] ZEPPELIN-959: Fix odd code block in writingzeppelininterpreter.md
879b8f9 [AhyoungRyu] Revert "ZEPPELIN-959: Fix odd code blocks in some documentations"
967b2fa [AhyoungRyu] ZEPPELIN-959: Fix odd code blocks in some documentations
@minahlee
Copy link
Copy Markdown
Member Author

minahlee commented Jun 8, 2016

Merge if there is no more discussion

@asfgit asfgit closed this in 70ab1a3 Jun 8, 2016
asfgit pushed a commit that referenced this pull request Jun 8, 2016
### What is this PR for?
Apply same style in website main page as #962

### What type of PR is it?
Documentation

### What is the Jira issue?
[ZEPPELIN-952](https://issues.apache.org/jira/browse/ZEPPELIN-952)

### Screenshots (if appropriate)
**Before**
<img width="1184" alt="screen shot 2016-06-04 at 10 17 34 pm" src="https://cloud.githubusercontent.com/assets/8503346/15803735/32142684-2aa2-11e6-9b9e-b4db1673f2fd.png">

**After**
<img width="1184" alt="screen shot 2016-06-04 at 10 17 23 pm" src="https://cloud.githubusercontent.com/assets/8503346/15803734/2f0771e4-2aa2-11e6-888a-d2d0852bb92a.png">

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Mina Lee <minalee@nflabs.com>

Closes #963 from minahlee/gh-page/ZEPPELIN-952 and squashes the following commits:

f862dac [Mina Lee] prettify document
5f7e885 [Mina Lee] remove incubating from mailing list url
@minahlee minahlee deleted the ZEPPELIN-952 branch August 8, 2016 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants