[ZEPPELIN-890] Cache downloaded file from 'maven-download-plugin' #996
Closed
Leemoonsoo wants to merge 2 commits into
Closed
[ZEPPELIN-890] Cache downloaded file from 'maven-download-plugin' #996Leemoonsoo wants to merge 2 commits into
Leemoonsoo wants to merge 2 commits into
Conversation
Leemoonsoo
changed the title
Contributor
|
One more suggestion not sure if that is relevant to this PR should we have |
Member
Author
|
@prabhjyotsingh Thanks for suggestion. Once travis caches '.m2/repository/.cache/maven-download-plugin' directory, 'maven-download-plugin' will not even try to download files from internet. So i think i'll be okay without increasing retry count. |
Contributor
|
Thank you for the explanation, I understand it now. |
Member
Author
|
Merge if there're no further discussions |
Contributor
|
Sure, I think we can merge this as a hotfix. |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Cache downloaded file from 'maven-download-plugin' to improve CI build speed and reduce build failure due to network issue.
What type of PR is it?
Improvement
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-890
Questions: