ZOOKEEPER-3870: Avoid out of order response and txns created with ReadOnlyZooKeeperServer - #1387
Open
lvfangmin wants to merge 1 commit into
Open
ZOOKEEPER-3870: Avoid out of order response and txns created with ReadOnlyZooKeeperServer#1387lvfangmin wants to merge 1 commit into
lvfangmin wants to merge 1 commit into
Conversation
Contributor
|
Checkstyle is failing. |
hanm
reviewed
Jun 25, 2020
| Assert.assertTrue(getResponseLatch.await(2, TimeUnit.SECONDS)); | ||
| Assert.assertTrue(setResponseLatch.await(2, TimeUnit.SECONDS)); | ||
| Assert.assertEquals(requestCount, successGetResponseCount.get()); | ||
|
|
Contributor
There was a problem hiding this comment.
How would these three Assert verify the order of the responses?
Contributor
|
#1380 landed so this one is good to go. "just" need a rebase and fixing check style errors |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.